Adar Dembo has posted comments on this change. Change subject: log block manager: convert container metrics from counters to gauges ......................................................................
Patch Set 1: (2 comments) > (2 comments) > > before committing we should make sure that consumers of this won't > get too confused with the metric type change Yes, I'll be testing this. http://gerrit.cloudera.org:8080/#/c/6823/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS1, Line 108: Counters > containers? Done Line 161: #undef MINIT > remove Done -- To view, visit http://gerrit.cloudera.org:8080/6823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I343d99d42da7f4fbc0facb476c97f2ca8785031d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
