Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 29: (6 comments) yep, it's been nits for the last 3 revisions :) http://gerrit.cloudera.org:8080/#/c/6170/29/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: PS29, Line 163: cluster_->Shutdown(); > nit dont need this, the emc already shutsdown on the dctor Done http://gerrit.cloudera.org:8080/#/c/6170/29/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS29, Line 500: might happen in case of a > how about: can only happen in a Done PS29, Line 1026: PKI > here and elsewhere, we tag our TODOs with usernames in most places As I can see from the code, the better approach is to use TODO(KUDU-xxx) to have better tracking of issues. For this particular case, KUDU-1920 is opened. PS29, Line 4126: "uninitialized" > this is redundant Done http://gerrit.cloudera.org:8080/#/c/6170/29/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: PS29, Line 360: // Calling this method makes sense only if leader_status.ok(). > How about: Requires: leader_status() returns OK() Done http://gerrit.cloudera.org:8080/#/c/6170/29/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: PS29, Line 202: that's a > remove Done -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 29 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
