Adar Dembo has posted comments on this change. Change subject: log block manager: reopen container metadata writers at the OS level ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6825/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 2201: w.reset(new WritablePBContainerFile(std::move(f))); > semi-unrelated question: now that we've had the file cache for a while and Sure, will do it in a follow-on patch. http://gerrit.cloudera.org:8080/#/c/6825/2/src/kudu/util/pb_util.h File src/kudu/util/pb_util.h: PS2, Line 280: Init > maybe best to rename this to OpenNew and the one below OpenForAppend or Ope OK, I'll use CreateNew() and OpenExisting(). -- To view, visit http://gerrit.cloudera.org:8080/6825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6029d499422f5a2db036d796c7e208f2af71c394 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
