David Ribeiro Alves has posted comments on this change. Change subject: log: release WritableLogSegment buffers when log is idle ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6611/3/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: PS3, Line 199: 1 flag? http://gerrit.cloudera.org:8080/#/c/6611/3/src/kudu/consensus/log.h File src/kudu/consensus/log.h: Line 90: extra line PS3, Line 99: Status SwitchToAsyncMode(); this new state change seems weird because it's one way. could we just refactor Append to just be wrapper around Status AsyncAppend(std::unique_ptr<LogEntryBatch> entry_batch, const StatusCallback& callback) and always have the log in async mode? do you think there would be a perf impact? -- To view, visit http://gerrit.cloudera.org:8080/6611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512c7f9264ac9490e6a57259e4d7b2608adc1ca7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
