Adar Dembo has posted comments on this change. Change subject: block manager: require file cache ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6880/1/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: PS1, Line 48: if (value == 0) { : LOG(ERROR) << "Invalid max open files: cannot be 0"; : return false; : } : return true; > you think there's any value in making sure it's at least something semi-rea Dan asked me that when I was first committing the file cache code. Specifically he was wondering whether performance fell off a cliff when max_open_files was below a certain amount. The short answer is that I don't know; it'd depend a lot on what kind of workloads were being run. I also don't think it's worth worrying about since the gflag is already rather obscured. If I'm wrong and it turns out that users use this as a footgun more often than not, I'll run some workloads to establish a reasonable minimum and add it to the validator. -- To view, visit http://gerrit.cloudera.org:8080/6880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9946e537e0b4abd66a9a90fc05df04232db68bc0 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
