Adar Dembo has submitted this change and it was merged. Change subject: fs_manager: optimize tmp file deletion ......................................................................
fs_manager: optimize tmp file deletion In a run of dense_node-itest, the bulk of CPU time[1] was spent canonicalizing paths while cleaning up temporary files. This patch optimizes that in two ways: - Stop canonicalizing paths. We already canonicalize the WAL and data dir roots; that's good enough for admin-provided symlinks. - Split WAL and data root cleaning, parallelizing the latter through the DataDirManager. 1. Though admittedly the majority of wall clock time was waiting on IO. Change-Id: I07830f0cc3fd5da847361607c62a369c39e677d2 Reviewed-on: http://gerrit.cloudera.org:8080/6837 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/util/env_util.cc M src/kudu/util/env_util.h 5 files changed, 67 insertions(+), 57 deletions(-) Approvals: Adar Dembo: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07830f0cc3fd5da847361607c62a369c39e677d2 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
