Will Berkeley has posted comments on this change.

Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:

Line 13: 2. /tablets has a toggle-collapse detailed table of tablets.
> I'm not sure this is an improvement, since there is no content under the ta
There's 4 possible elements in the tablets section
1. summary of live tablets
2. table of live tablets
3. summary of tombstoned tablet
4. table of tombstoned tablets
so having the tablets tables collapsed shows the 1-2 summaries. Previously, if 
there were tombstoned tablets, info about them would be hidden below the live 
tablets table.


Line 29: Also I added a memory usage column to the detailed tablets
> I'm concerned it may be misleading to call this 'memory usage', since it on
It's not too jargony if it's correct and avoids the number being misleading. 
But I'm not familiar with how the mem trackers are working-- is it only 
tracking the write buffers because block caches, logs, etc are owned by 
different trackers?


-- 
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to