Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement ......................................................................
Patch Set 29: (4 comments) http://gerrit.cloudera.org:8080/#/c/6636/24/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS24, Line 412: other > nit: in other places in this file this kind of statement is written as 'if Done PS24, Line 529: data_dir_set.insert(group_indices.begin(), group_indices.end()); : for (auto& e : data_dir_by_uuid_idx_) { : > nit: since it's C++11, consider Neat! Done PS24, Line 532: URN_ > nit: auto& ? Done http://gerrit.cloudera.org:8080/#/c/6636/24/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: PS24, Line 20: #include <memory> > nit: per code style this should be placed after std and before kudu headers Done -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9828147f4fa5c4d7f6ed23441dca5a116b8cb11b Gerrit-PatchSet: 29 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
