Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs ......................................................................
Patch Set 10: Code-Review+1 (1 comment) Looks good to me, just one nit. http://gerrit.cloudera.org:8080/#/c/6809/10/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: PS10, Line 199: nit: sorry to nitpick so hard on this, can we just align this opening quote with the opening quote on the above line? The GSG says it best: https://google.github.io/styleguide/cppguide.html#Function_Calls If the arguments do not all fit on one line, they should be broken up onto multiple lines, with each subsequent line aligned with the first argument. Do not add spaces after the open paren or before the close paren: bool result = DoSomething(averyveryveryverylongargument1, argument2, argument3); -- To view, visit http://gerrit.cloudera.org:8080/6809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc4bdd9752fc29a7ce2cefcdc95c4366f5353af Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
