Dan Burkert has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs ......................................................................
Patch Set 35: (2 comments) http://gerrit.cloudera.org:8080/#/c/6514/35/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 96: vector<Network>* g_local_networks = nullptr; Instead of only caching local_networks, could you cache the full set of trusted networks? That way the trusted_subnets flag wouldn't need to be reparsed for every connection. http://gerrit.cloudera.org:8080/#/c/6514/35/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: Line 22: #include <ifaddrs.h> insert this in alphabetical order -- To view, visit http://gerrit.cloudera.org:8080/6514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c3fbb5491785874c5701d6c9d866949cfac905e Gerrit-PatchSet: 35 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Harsh J <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
