Will Berkeley has posted comments on this change. Change subject: KUDU-2016: Fix Java client's ColumnSchema.getDefaultValue() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6903/1//COMMIT_MSG Commit Message: Line 7: Fix Java client's ColumnSchema.getDefaultValue() > Is this KUDU-2016? If so, add that to the message. Done http://gerrit.cloudera.org:8080/#/c/6903/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: Line 154: public void testAlterModifyColumns() throws Exception { > Probably worth adding a similar test to C++, if it's not already covered. The C++ client actually doesn't have getters for default/encoding/compression in KuduColumnSchema. Something to be added later I guess? -- To view, visit http://gerrit.cloudera.org:8080/6903 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifacb860a34cb860ff9e03020f2d5683c9ba6fa46 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
