Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1294 fix issue with unreleased consumption ......................................................................
KUDU-1294 fix issue with unreleased consumption In DEBUG builds, the DCHECK assert on unreleased consumption fires from time to time in the destructor of MemTracker objects. The root cause was found by Todd and described in the first comment on KUDU-1294. This patch fixes the issue by re-ordering the sequence of removing the transaction driver from the map and releasing its memory consumption. As a test, I ran 1K+ iterations of security-faults-itest test built in DEBUG configuration with --stress-cpu-threads=8. Prior to this fix, usually ~15 out of 1024 tests were failing due to the issue: http://dist-test.cloudera.org//job?job_id=aserbin.1494966417.6076 After the fix, there were not any failures in the whole 1K run: http://dist-test.cloudera.org//job?job_id=aserbin.1494963982.18117 Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743 Reviewed-on: http://gerrit.cloudera.org:8080/6901 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/tablet/transactions/transaction_tracker.cc 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6901 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41d4fd4c0030af02ae5b1e83bd52833632ed6743 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
