Adar Dembo has posted comments on this change. Change subject: locks: allow use of TSAN on many-core machines ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6905/1//COMMIT_MSG Commit Message: PS1, Line 11: can make the : results a little harder to read, this changes percpu_rwlock in TSAN builds : to just use a simple lock. Is there any danger that TSAN won't notice a race if we're using only one lock, though? That is, is there any race that TSAN couldn't detect by virtue of not being exposed to the implementation that uses the entire lock array? http://gerrit.cloudera.org:8080/#/c/6905/1/src/kudu/util/locks.h File src/kudu/util/locks.h: Line 162: // OSX doesn't have a way to get the CPU, so we'll just use a single lock. Nit: I know you just copied the comment, but can you change "get the CPU" to something more precise like "get the index of the CPU running this thread"? -- To view, visit http://gerrit.cloudera.org:8080/6905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b41a5bbdbef9046b07d2908b2b824bb9dd2b76 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
