David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2017. Fix calculation of perf improvement for flushes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6908/1/src/kudu/tablet/tablet_replica_mm_ops.cc File src/kudu/tablet/tablet_replica_mm_ops.cc: PS1, Line 75: double anchored_mb = static_cast<double>(stats->ram_anchored()) / (1024 * 1024); nit: could we declare this above the if stmt and avoid doing the conversion to mb twice? -- To view, visit http://gerrit.cloudera.org:8080/6908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bcf443db857ce172b8e83758eb73a24c4b0c6af Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
