William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread ......................................................................
Patch Set 11: (14 comments) all are related to the missing <atomic> header file. fixed. http://gerrit.cloudera.org:8080/#/c/6853/10/src/kudu/util/logging-test.cc File src/kudu/util/logging-test.cc: Line 103: int /*message_len*/) override { > error: use of undeclared identifier 'message_count_' [clang-diagnostic-erro Done Line 112: SleepFor(MonoDelta::FromMilliseconds(5)); > error: use of undeclared identifier 'flush_count_' [clang-diagnostic-error] Done Line 119: > error: expected member name or ';' after declaration specifiers [clang-diag Done Line 119: > error: no type named 'atomic' in namespace 'std' [clang-diagnostic-error] Done Line 120: std::atomic<int> flush_count_ = {0}; > error: no type named 'atomic' in namespace 'std' [clang-diagnostic-error] Done Line 120: std::atomic<int> flush_count_ = {0}; > error: expected member name or ';' after declaration specifiers [clang-diag Done Line 156: async.Stop(); > error: no member named 'message_count_' in 'kudu::CountingLogger' [clang-di Done Line 156: async.Stop(); > error: no type named 'Compare' in the global namespace [clang-diagnostic-er Done Line 156: async.Stop(); > error: expected ')' [clang-diagnostic-error] Done Line 160: // 'flush' set to true. > error: no member named 'flush_count_' in 'kudu::CountingLogger' [clang-diag Done Line 178: ASSERT_EVENTUALLY([&]() { > error: no type named 'Compare' in the global namespace [clang-diagnostic-er Done Line 178: ASSERT_EVENTUALLY([&]() { > error: expected ')' [clang-diagnostic-error] Done Line 178: ASSERT_EVENTUALLY([&]() { > error: no member named 'message_count_' in 'kudu::CountingLogger' [clang-di Done Line 181: // so there should be no more messages in the buffer. > error: no member named 'flush_count_' in 'kudu::CountingLogger' [clang-diag Done -- To view, visit http://gerrit.cloudera.org:8080/6853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4c6d440e9259efcf222530f13137f7de5bf00fc Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: William Li <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: William Li <[email protected]> Gerrit-HasComments: Yes
