Hao Hao has posted comments on this change.

Change subject: kudu-2022 Fix nullptr access at GetLocalNetworks.
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > This isn't testable without mocking a response from getifaddrs(),
 > right? Probably not worth it.

Right... not sure what is an easy way to do so.

-- 
To view, visit http://gerrit.cloudera.org:8080/6931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0118336672b0533b79d9878f851af3bbc78452b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No

Reply via email to