Alexey Serbin has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6945/2/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: PS2, Line 153: shared_ptr<Runnable>(new SlowTask(latch)); nit: consider using std::make_shared<SlowTask>(latch) instead PS2, Line 229: pool_->Wait(); : pool_->Shutdown(); What if one of asserts above triggers due to a failure? Would it be necessary to call Shutdown() on pool_ or it's will be cleaned up automatically somewhere else? -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37d0bd0a05098bcc1a81ec9f1ac33e74e98781e4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
