Alexey Serbin has posted comments on this change. Change subject: Move CreateTableForTesting into registration-test ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6961/2/src/kudu/integration-tests/registration-test.cc File src/kudu/integration-tests/registration-test.cc: PS2, Line 69: CreateTableRequestPB req; : CreateTableResponsePB resp; It seems this requires either to be in 'namespace master', or 'using namespace master' in the body of the function, or just adding 'using master::CreateTableRequestPB' and other related PB types above. Overall, LGTM. -- To view, visit http://gerrit.cloudera.org:8080/6961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id72a37b2dee05db65f27c27d52b0f18dd5c489f2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
