Mike Percy has submitted this change and it was merged. Change subject: Improve ASSERT_STR_CONTAINS() ......................................................................
Improve ASSERT_STR_CONTAINS() This can just defer to built-in gtest functions instead of being constructed by us. The benefit is that the implementation doesn't have to wrap the macro in a do ... while loop so we are able to use syntax like: ASSERT_STR_CONTAINS(a, b) << extra_info; whereas previously you couldn't append extra_info to the error message. Also fix some uses of ASSERT_STR_CONTAINS that were missing semicolons. Change-Id: Idea2abc0115e13dbb9f3853a5b821ccbf833d184 Reviewed-on: http://gerrit.cloudera.org:8080/6956 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/integration-tests/master_replication-itest.cc M src/kudu/master/master-test.cc M src/kudu/util/debug-util-test.cc M src/kudu/util/flags-test.cc M src/kudu/util/test_macros.h 5 files changed, 10 insertions(+), 19 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idea2abc0115e13dbb9f3853a5b821ccbf833d184 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
