Mike Percy has posted comments on this change. Change subject: KUDU-1580 retry tserver RPC if negotiation times out ......................................................................
Patch Set 6: (4 comments) I'm not sure what the purpose is of NEGOTIATION_TIMED_OUT in the current patch. http://gerrit.cloudera.org:8080/#/c/6926/4/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: Line 314: const MonoDelta timeout = controller_->timeout(); did you mean const& ? http://gerrit.cloudera.org:8080/#/c/6926/6/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: Line 330: return state_ == TIMED_OUT; return state_ == TIMED_OUT || state_ == NEGOTIATION_TIMED_OUT ? http://gerrit.cloudera.org:8080/#/c/6926/4/src/kudu/rpc/outbound_call.h File src/kudu/rpc/outbound_call.h: PS4, Line 124: remove remote http://gerrit.cloudera.org:8080/#/c/6926/6/src/kudu/rpc/rpc_introspection.proto File src/kudu/rpc/rpc_introspection.proto: Line 43: NEGOTIATION_TIMED_OUT = 7; I don't really understand why these are defined both here and in outbound_call.h, can't we just use these ones everywhere? -- To view, visit http://gerrit.cloudera.org:8080/6926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icee8bf4978365a23d6627e7bc411b63f53540a3b Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
