Adar Dembo has posted comments on this change. Change subject: KUDU-1988: add support for advertised host:port info. ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6827/12//COMMIT_MSG Commit Message: PS12, Line 10: Nit: don't need http://gerrit.cloudera.org:8080/#/c/6827/12/src/kudu/server/rpc_server-test.cc File src/kudu/server/rpc_server-test.cc: Line 99: TEST_F(BoundOnlyWebserverTest, OnlyBoundAddresses) { Should wrap these calls in NO_FATALS. http://gerrit.cloudera.org:8080/#/c/6827/12/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: Line 299: ASSERT_OK(server_->GetAdvertisedAddresses(&advertised_addrs)); Need to wrap these in NO_FATALS(). -- To view, visit http://gerrit.cloudera.org:8080/6827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6735ca5630fc4c426bf72d0b21d6ef452173a890 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Patrik Sundberg <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Patrik Sundberg <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
