Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools ......................................................................
Patch Set 5: PS5 yielded the following crash: https://gist.github.com/adembo/bb30754825ec0bf10cba783d07f3ac7d Looks like the last deref to the token shared between RaftConsensus and Peer happened _after_ RaftConsensus was destroyed, so when the token was destructed, its pool was already gone. Is this a sign that shared ownership of the token is a bad idea, and instead RaftConsensus should be the sole owner and share out its token via raw pointer to Peer? Does that make sense? -- To view, visit http://gerrit.cloudera.org:8080/6946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8958c607d11ac2e94908670c985059bef0ff5f54 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
