Alexey Serbin has posted comments on this change. Change subject: Work around another OpenSSL thread safety bug ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6997/2//COMMIT_MSG Commit Message: Line 19: ASAN_OPTIONS="fast_unwind_on_malloc=0" Thank you for putting this into the commit message. I remember Todd and/or you mentioned this in Slack some time ago, but it would be much easier to find it in the commit log. http://gerrit.cloudera.org:8080/#/c/6997/2/src/kudu/security/cert.cc File src/kudu/security/cert.cc: PS2, Line 60: InitializeOpenSSL(); Does it make sense to remove it from here at all and add one into Cert::KuduKerberosPrincipal()? The only call sites of GetKuduKerberosPrincipalOidNid() is CertRequestGenerator::Init() and Cert::KuduKerberosPrincipal() -- To view, visit http://gerrit.cloudera.org:8080/6997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a9fe1a32f77bf24a5c7e692a55b8ad96488d409 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
