Alexey Serbin has posted comments on this change. Change subject: consensus: Acquire lock before snoozing FD ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7010/1/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS1, Line 1328: SnoozeFailureDetectorUnlocked do you think it makes sense to add an assertion into the SnoozeFailureDetectorUnlocked(), like DCHECK(state_->update_lock_.is_locked()); ? -- To view, visit http://gerrit.cloudera.org:8080/7010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6f2a27847db7efe34409f2fe9c915318d755732 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
