Mike Percy has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7012/4/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: PS4, Line 117: State_Name > style nit: why not just state_name() or StateName()? State_Name() follows the convention used in protobuf which is used all over the place, so I thought it would be more intuitive, i.e. TabletStatePB_Name(). -- To view, visit http://gerrit.cloudera.org:8080/7012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6858752f4fbeb70b09eb4375c52e4aeaa1bb8e71 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
