Mike Percy has posted comments on this change. Change subject: consensus: Get rid of ReplicaState class ......................................................................
Patch Set 6: This version of the patch was run on dist-test for 500 runs under stress (8 cpus) on dist-test. Here are the stats: 60d8567 - consensus: Get rid of ReplicaState class http://dist-test.cloudera.org/job?job_id=mpercy.1496190840.22471 Failed tests: 13 RaftConsensusITest.TestMemoryRemainsConstantDespiteTwoDeadFollowers 10 RaftConsensusITest.TestCorruptReplicaMetadata 6 RaftConsensusITest.TestCommitIndexFarBehindAfterLeaderElection 1 RaftConsensusITest.TestAddRemoveServer Crashed tests: 2 RaftConsensusITest.InsertUniqueKeysWithCrashyNodes 2 RaftConsensusITest.InsertDuplicateKeysWithCrashyNodes 1 RaftConsensusITest.TestChurnyElections_WithDuplicateKeys 1 RaftConsensusITest.TestChurnyElections This is very similar to master, which was actually worse on multiple fronts but it looks like randomness: 8546583 - consensus: Acquire lock before snoozing FD http://dist-test.cloudera.org/job?job_id=mpercy.1496194229.20684 $ dist-test-failure-stats.sh Failed tests: 48 RaftConsensusITest.TestCommitIndexFarBehindAfterLeaderElection 18 RaftConsensusITest.TestMemoryRemainsConstantDespiteTwoDeadFollowers 8 RaftConsensusITest.TestCorruptReplicaMetadata 1 RaftConsensusITest.TestReplicaBehaviorViaRPC Crashed tests: 10 RaftConsensusITest.TestChurnyElections 2 RaftConsensusITest.InsertDuplicateKeysWithCrashyNodes 1 RaftConsensusITest.InsertUniqueKeysWithCrashyNodes -- To view, visit http://gerrit.cloudera.org:8080/7007 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e62eff37d3f8655100b364939375608063aa80 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
