Dan Burkert has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix ......................................................................
Patch Set 1: (2 comments) Nice, just a few style nits. I'd be in favor of cherry-picking this to 1.4. http://gerrit.cloudera.org:8080/#/c/7043/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 835: const vector<string> headers{"Config source", "Voters", "Current term", I think our style is to leave a space on both sides of open and close braces. Line 858: Substitute("$0", replica.consensus_state->term.get()) : ""); These substitutes would be simpler as calls to std::to_string. -- To view, visit http://gerrit.cloudera.org:8080/7043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d77005f20091e6778702580e3a269d9689c5b0a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
