Mike Percy has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: PS1, Line 136: has_leaks = __lsan_do_recoverable_leak_check(); > lsan_do_recoverable_leak_check already does print the leak to stderr. I sup I would agree w/ David if __lsan_do_recoverable_leak_check() didn't already log (I didn't know that either) but since it does then I think it would add unnecessary spam to the log. This seems fine. -- To view, visit http://gerrit.cloudera.org:8080/7052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
