Adar Dembo has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool ......................................................................
Patch Set 1: (4 comments) > curious whether you think this is still useful considering the > 'kudu pbc edit' that I also have up for review. > > This one is a little more constrained, which may be useful, but > maybe not worth it vs just having the editor? I definitely think this is useful, despite a more free-form editing tool. http://gerrit.cloudera.org:8080/#/c/7049/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: Line 1486: ASSERT_OK(mini_cluster_->WaitForTabletServerCount(1)); This is guaranteed by MiniCluster::Start(). http://gerrit.cloudera.org:8080/#/c/7049/1/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: Line 310: cmeta->clear_voted_for(); Why is it important to do this? I can take my answer in the form of a code comment. Line 798: .Description("Bump the current term stored in consensus metadata") Maybe add that the new term must be greater than the old one? Either here or in ExtraDescription. PS1, Line 800: "term" Since this is used in two places, our convention has been to hide it behind a kBlahArg constant. -- To view, visit http://gerrit.cloudera.org:8080/7049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7525ffbe772f214e0972a6b450f3f1609109ca05 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
