Andrew Wong has posted comments on this change. Change subject: WIP Don't suicide on EIO ......................................................................
Patch Set 11: (17 comments) This patch has been split into a few smaller ones! Will abandon this one. http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 24: #include <set> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 310: RETURN_NOT_OK_PREPEND(tablet_replica_->Init(tablet, > warning: missing username/bug in TODO [google-readability-todo] This TODO isn't actionable. Removed. http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: Line 172: void AddOrphanedBlocks(const std::vector<BlockId>& blocks); > warning: function 'kudu::tablet::TabletMetadata::AddOrphanedBlocks' has a d Changed to 'blocks' to align with other functions. http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: Line 2490 > error: use of undeclared identifier 'set' [clang-diagnostic-error] Done Line 2490 > error: use of undeclared identifier 'failed_data_dirs' [clang-diagnostic-er Done Line 2490 > error: unexpected type name 'uint16_t': expected expression [clang-diagnost Done Line 2491 > error: use of undeclared identifier 'failed_data_dirs' [clang-diagnostic-er Done Line 2492 > error: use of undeclared identifier 'failed_data_dirs' [clang-diagnostic-er Done Line 2505 > error: use of undeclared identifier 'failed_data_dirs' [clang-diagnostic-er Done Line 2506 > error: use of undeclared identifier 'failed_data_dirs' [clang-diagnostic-er Done http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1085: > error: unknown type name 'set'; did you mean 'std::set'? [clang-diagnostic- Done Line 1085: > warning: all parameters should be named in a function [readability-named-pa Done Line 1085: > error: expected ')' [clang-diagnostic-error] Done Line 1088: // middle of a bootstrap, tablet copy, etc. > error: reference to type 'const string' (aka 'const basic_string<char>') co Done Line 1088: // middle of a bootstrap, tablet copy, etc. > error: use of undeclared identifier 'tablet_ids'; did you mean 'tablet_id'? Done http://gerrit.cloudera.org:8080/#/c/6773/10/src/kudu/util/status.h File src/kudu/util/status.h: Line 100: if (s.posix_code() == (err_number)) (err_handler); \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done Line 108: if (s.posix_code() == (err_number)) (err_handler); \ > warning: macro argument should be enclosed in parentheses [misc-macro-paren Done -- To view, visit http://gerrit.cloudera.org:8080/6773 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c221a5ea97c7b7ec5f8d395b5527dc16e63f828 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
