Adar Dembo has posted comments on this change. Change subject: Bump googletest ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7089/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 330: -DCMAKE_INSTALL_PREFIX=$PREFIX \ We end up building gmock twice (once for shared and once for static); I presume its install logic is smart enough for both libraries to exist in the destination prefix at the same time? And could you also check that both gmock and gtest headers are placed in the right location? -- To view, visit http://gerrit.cloudera.org:8080/7089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cf6eee7007857f66b4177d3bfed665d8702e37f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
