Mike Percy has posted comments on this change. Change subject: tool: add a 'pbc edit' command ......................................................................
Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/tool_action_pbc.cc File src/kudu/tools/tool_action_pbc.cc: PS1, Line 142: tmp_template), > mktemp unfortunately requires the last 6 characters to be XXXXXX. Added the ah, we would have to use mkstemps(). ok forget it Line 173: for (const string& l : lines) { > Yeah I'm fine with deferring this improvement for later. Yeah, that's fine. -- To view, visit http://gerrit.cloudera.org:8080/7048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9434935469df8978a4f3fb3719f0245499aece5 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
