Adar Dembo has posted comments on this change. Change subject: KUDU-2003. Fix fd-cache related tests on high-core systems ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7160/2/src/kudu/util/file_cache-stress-test.cc File src/kudu/util/file_cache-stress-test.cc: Line 93: // Use a single shard. Otherwise, the cache can be a little bit "sloppy" The main downside of using a single shard (and the reason I didn't do that when I added the test) is poorer coverage of the cache sharding. Do we get adequate coverage of that elsewhere? -- To view, visit http://gerrit.cloudera.org:8080/7160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd901730f16c70bb2e4a60464ab08a9a6f14c32f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
