Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate fs error handling ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7029/3/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: PS3, Line 26: #include <set> > include ordering Done http://gerrit.cloudera.org:8080/#/c/7029/3/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: PS3, Line 27: EioHandleableImpl > weird to be calling an interface "impl". also not sure about the interface Right, should be an Interface. The "contract" here is in order to make use of KUDU_RETURN_OR_HANDLE_EIO, the caller _must_ implement EioHandleableIf. http://gerrit.cloudera.org:8080/#/c/7029/3/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: PS3, Line 685: LOG(WARNING) << Substitute("Block $0 is on a disk that has failed: $1", : block_id.ToString(), : dd_manager_.FindDataDirByUuidIndex(uuid_idx)->dir()); > isn't this gonna spam the log if we delete a whole tablet? Right.. would VLOG(1) or something bet better here? I think it'd be weird to do nothing, but not sure how to accomplish that without being spammy in some cases. http://gerrit.cloudera.org:8080/#/c/7029/3/src/kudu/fs/file_block_manager.h File src/kudu/fs/file_block_manager.h: PS3, Line 77: FsErrorManager* error_manager = nullptr > why allow this to be null? is that because of tests? Yeah, i've removed this so it must not be null. -- To view, visit http://gerrit.cloudera.org:8080/7029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3169deada702c527b70fabf9d2223364f9a9ea6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
