Alexey Serbin has posted comments on this change. Change subject: KUDU-2042 fix flakiness in raft_consensus-itest ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7227/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 304: } while (true); > instead of this loop, could we introduce a function like: Ha! Just thought about that while preparing this patch and looking at ts_itest-base.h and decided to go with re-tries since it seemed to me that the 'atomic' snapshot approach would not catch as many re-elections as the 'retry' approach. OK, I'll do the 'atomic' approach, moving the retry into the function itself. -- To view, visit http://gerrit.cloudera.org:8080/7227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5fb2b82afb15b50659d068ef83d11b7cc291ca9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
