Adar Dembo has posted comments on this change. Change subject: kserver: introduce KuduServer class ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7239/1/src/kudu/master/master.h File src/kudu/master/master.h: Line 29: #include "kudu/master/master_options.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/7239/1/src/kudu/tserver/tablet_server.h File src/kudu/tserver/tablet_server.h: Line 47: // TODO: move this out of this header, since clients want to use this > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/7239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ffd09ce46d9d744aa25343cec77b7a33b88563 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
