Sam Okrent has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7249/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: Line 273: RETURN_NOT_OK(Env::Default()->FileIsWorldReadable(FLAGS_rpc_private_key_file, > did you try adding this check to the ValidateExternalPkiFlags method? I th Okay, do you think I should move the keytab file check to a validator as well? Line 274: &world_readable_private_key)); > alignment Done Line 276: return Status::InvalidArgument(Substitute( > Same comment about InvalidArgument as in the other check. Done http://gerrit.cloudera.org:8080/#/c/7249/2/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 455: return Status::InvalidArgument(Substitute( > Status::InvalidArgument can take an optional second string parameter which Done http://gerrit.cloudera.org:8080/#/c/7249/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS2, Line 1564: OVERRIDE > use lowercase 'override' Done -- To view, visit http://gerrit.cloudera.org:8080/7249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ee84e71023304f0743ba0ad37ebb1eef24abc6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
