David Ribeiro Alves has posted comments on this change. Change subject: WIP: Ensure ConsensusMetadata exists, even for tombstoned tablets ......................................................................
Patch Set 1: (5 comments) just browsed this one since it seems like it needs updating. the approach in general seems sound. I particularly like the avoidance of re-vivifying the replica. http://gerrit.cloudera.org:8080/#/c/6957/1//COMMIT_MSG Commit Message: PS1, Line 16: 1) Allow RaftConsensus to operate while not initialized or in a shutdown : state. Also pass ConsensusMetadata into the RaftConsensus : constructor. > The problem is that I need to provide a long lived object (see patch 3 in t Mike: can you move some of this info to the commit message? http://gerrit.cloudera.org:8080/#/c/6957/3/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS3, Line 900: all of that data over to the 2nd tablet se would the test fail if we kept it running? if so say why, if not consider leaving it running PS3, Line 919: for (const Status& s : statuses) { check the returned status http://gerrit.cloudera.org:8080/#/c/6957/3/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: PS3, Line 317: didn't you get rid of this method? still working on propagating those changes? http://gerrit.cloudera.org:8080/#/c/6957/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS1, Line 1061: // If we are missing the ConsensusMetadata file then we will ultimately log : // a FATAL. not sure what this means? -- To view, visit http://gerrit.cloudera.org:8080/6957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia27a091d27b3996d37009d5ec866e744f9608388 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
