Alexey Serbin has posted comments on this change. Change subject: [client-test] fixing flakes in the test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7263/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 5131: MonoDelta::FromSeconds(60), // client_timeout > Does this mean the test that took 10s now takes 60s? Not necessarily. I decided to go with 60 seconds because it's a big margin over the expected run-time of the test, which in most cases should be much less that 10 seconds. Only in some rare cases creation of a table takes that long, and the timeout has been increased to cover those cases. But to some extent -- yes, in the case of that mishap and running the test for a long time, it could happen that instead of failing after 10 seconds the test would run 20 seconds and finish successfully. -- To view, visit http://gerrit.cloudera.org:8080/7263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0203e62ec8ee445201e385816f3c05c2594356d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
