Alexey Serbin has posted comments on this change.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
Line 36: using std::vector;
> Nit: out of order.
Done
Line 79: master_.reset();
> Nit: may as well move this into the if block.
Done
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.h
File src/kudu/master/mini_master.h:
Line 64: bool is_started() const { return master_.get() != nullptr; }
> warning: redundant get() call on smart pointer [google-readability-redundan
Done
Line 80: Status StartOnPorts(uint16_t rpc_port, uint16_t web_port,
> warning: function 'kudu::master::MiniMaster::StartOnPorts' has a definition
Done
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/tserver/mini_tablet_server.h
File src/kudu/tserver/mini_tablet_server.h:
Line 94: bool is_started() const { return server_.get() != nullptr; }
> warning: redundant get() call on smart pointer [google-readability-redundan
Done
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes
