David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7273/1/src/kudu/integration-tests/mini_cluster.h File src/kudu/integration-tests/mini_cluster.h: PS1, Line 44: InternalMiniCluster this is the base for both impls right? (guess this comment belongs to the previous patch) PS1, Line 47: MiniCluster whats the motivation behind the rename? the base suffix usually refers to an "abstract" class, which this is, and we don't usually use the implementations interchangeably. -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40273d6ca7ac5fdc4cf2a6de374d374fe86cbf36 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
