Sam Okrent has posted comments on this change. Change subject: KUDU-1955 refuse to use world-readable keytabs ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7249/6/src/kudu/security/init.cc File src/kudu/security/init.cc: PS6, Line 57: security_ > Is this crucial to have 'security' as the part of the flag? Done PS6, Line 58: this server > This file is linked into non-server components as well (e.g., the kudu CLI Done http://gerrit.cloudera.org:8080/#/c/7249/6/src/kudu/util/env.h File src/kudu/util/env.h: PS6, Line 334: FileIsWorldReadable > Given the naming scheme seen in this file, this should be names Done -- To view, visit http://gerrit.cloudera.org:8080/7249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2ee84e71023304f0743ba0ad37ebb1eef24abc6 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
