Mike Percy has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers. ......................................................................
Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7252/2/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 89: ::testing::Values("--block_manager=log","--block_manager=file")); You will need to avoid --block_manager=log on macOS. You can do that with something like this: #if defined(__APPLE__) static const char* block_mgr_flags[] = {"--block_manager=file"}; #else static const char* block_mgr_flags[] = {"--block_manager=log", "--block_manager=file"}; #endif INSTANTIATE_TEST_CASE_P(BlockManagerType, TsRecoveryITest, ::testing::ValuesIn(block_mgr_flags)); Line 96: // Add the block manager type Nit: period at end of sentence Line 137: Nit: spurious extra line PS2, Line 142: vector<string> extra_tserver_flags = {}; : extra_tserver_flags.emplace_back(GetParam()); instead of copy / pasting this in each test can we do this in the test constructor and have a vector with tserver flags ready to use here? Line 145: Nit: spurious extra line Line 161: cluster_->SetFlag(cluster_->tablet_server(0), If this is a test fix, please split it into its own commit instead of including it with this unrelated patch. Line 221: cluster_->tablet_server(0)->mutable_flags()->push_back(parameter_flag); Are you sure this is required? I think this is only for the dynamic flags we set using SetFlag(). PS2, Line 540: { nit: space before opening brace -- To view, visit http://gerrit.cloudera.org:8080/7252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bf8c4ef45d907f17366776dace9fecd95120821 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
