Andrew Wong has posted comments on this change. Change subject: disk failure: make DataDirManager failure-aware ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/7028/11/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS11, Line 471: ainsKey(group_by_tablet_map_, tabl > maybe put the cast around size() instead of the result of the subtraction? Done PS11, Line 622: shared_lock<rw_spinlock> lock( > missing a '!'? Done Line 632: std::lock_guard<percpu_rwlock> lock(dir_group_lock_); > can we DCHECK_LT(uuid_idx, data_dirs_.size()) or something? especially with Done -- To view, visit http://gerrit.cloudera.org:8080/7028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee212793152de5de5198751d649ab34fb97f6aa2 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
