Adar Dembo has posted comments on this change. Change subject: stopwatch: ensure LOG_TIMING always prints ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7333/1/src/kudu/util/stopwatch.h File src/kudu/util/stopwatch.h: Line 330: // TODO(todd): for some reason, times.wall_millis() sometimes ends up negative Did you add a CHECK() for that case? Did it produce anything interesting? -- To view, visit http://gerrit.cloudera.org:8080/7333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67fe658801be153cbcb6efb31cc8f3bf9eaf944f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
