Mike Percy has submitted this change and it was merged. Change subject: raft_consensus: failure detector doesn't need external synchronization ......................................................................
raft_consensus: failure detector doesn't need external synchronization While working with TimerFailureDetector I saw that it's thread-safe through and through. Thus, RaftConsensus doesn't need to externally synchronize it. So I renamed some functions and removed a few lock acquisition sites. AFAICT, the only reason not to do this is for one of the overloads of SnoozeFailureDetector() which calls LOG_WITH_PREFIX_UNLOCKED(). I don't think that's useful enough to warrant the locking, though. Change-Id: I637030c3ae2470aa0a8e1067ac6a9b69ea1793b4 Reviewed-on: http://gerrit.cloudera.org:8080/7329 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <[email protected]> --- M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus.h 2 files changed, 29 insertions(+), 35 deletions(-) Approvals: Mike Percy: Looks good to me, approved Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I637030c3ae2470aa0a8e1067ac6a9b69ea1793b4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
