Mike Percy has posted comments on this change. Change subject: kserver: consolidate randomized failure monitors ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7330/1/src/kudu/kserver/kserver.cc File src/kudu/kserver/kserver.cc: Line 92: failure_monitor_(GetRandomSeed32(), > we used to have a different seed for each tablet's FailureMonitor, and now Agreed. One thing we could consider is scheduling failure callbacks with some random jitter after we have determined they have failed, maybe with one additional last-second check that they didn't recover during that small window. -- To view, visit http://gerrit.cloudera.org:8080/7330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I096e3e89bf6e8925f6ea0382fc319d7382237787 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
