Alexey Serbin has posted comments on this change. Change subject: java: refactor ITClientStress for more reusable code ......................................................................
Patch Set 1: (3 comments) lgtm, just a couple of nits and a question on the copyright headers comments style (just for my education) http://gerrit.cloudera.org:8080/#/c/7360/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java: PS1, Line 1: // Licensed to the Apache Software Foundation (ASF) under one : // or more contributor license agreements. See the NOTICE file : // distributed with this work for additional information : // regarding copyright ownership. The ASF licenses this file : // to you under the Apache License, Version 2.0 (the : // "License"); you may not use this file except in compliance : // with the License. You may obtain a copy of the License at : // : // http://www.apache.org/licenses/LICENSE-2.0 : // : // Unless required by applicable law or agreed to in writing, : // software distributed under the License is distributed on an : // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY : // KIND, either express or implied. See the License for the : // specific language governing permissions and limitations : // under the License. While you are it, I wanted to clarify one stylistic nit: what sort of comments is proper for those copyright headers? One-liner like these or c-style ones? In Sun java sources I mostly see c-style ones. PS1, Line 65: ; nit: extra semicolon PS1, Line 73: pool.awaitTermination(10, TimeUnit.SECONDS); nit: maybe, wrap it with assertTrue() ? -- To view, visit http://gerrit.cloudera.org:8080/7360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I263b5681b52df0fa496cce2f58c0605c66810e64 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
