Alexey Serbin has posted comments on this change. Change subject: [net_util] fix reporting getaddrinfo() error ......................................................................
Patch Set 2: (3 comments) > If it's not too difficult, could you add sample output before/after > to the commit message? Sure, I can add an example. http://gerrit.cloudera.org:8080/#/c/7368/2/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: Line 312: Substitute("Unable to lookup canonical name for '$0'", *hostname), > perhaps we should be specific here and say "canonical name for localhost '$ This sounds good -- will add. Line 313: gai_strerror(rc)); > 1. For clarity, instead of "canonical name", can we say "canonical hostname 1. Sounds good 2. I did that first, but then I found it does not work on OS X . If we really want this to be present, then it will be if-defed then. Line 313: gai_strerror(rc)); > small nit in mike's code: should probably save 'errno' to a local as soon a That's the next thing I wanted to clean in this file -- delivering errno as returned from the libc calls. -- To view, visit http://gerrit.cloudera.org:8080/7368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d5ba87b9ea050724367610461bae22c9471a103 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
