Adar Dembo has posted comments on this change. Change subject: thirdparty: use ninja when possible ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7461/1//COMMIT_MSG Commit Message: PS1, Line 10: less ugly output. What's the difference here? And is it still less ugly when outputting to something that's not a real terminal? http://gerrit.cloudera.org:8080/#/c/7461/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 54: # If ninja is on the path, use that instead of make for a slightly Would prefer if this happened in build-thirdparty.sh; this file only defines functions, it doesn't actually run anything when sourced. Line 97: build_cmake() { What about here? If it can't work, add a comment explaining why? -- To view, visit http://gerrit.cloudera.org:8080/7461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacd6d8bc9ad371c3c925f7c628ad69785bb870e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
